Skip to content

bpo-40077: Convert _bz2 module to use PyType_FromSpec#20960

Merged
corona10 merged 9 commits intopython:masterfrom
corona10:bpo-40077-bz2
Jun 19, 2020
Merged

bpo-40077: Convert _bz2 module to use PyType_FromSpec#20960
corona10 merged 9 commits intopython:masterfrom
corona10:bpo-40077-bz2

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Jun 18, 2020

@corona10 corona10 marked this pull request as draft June 18, 2020 13:15
@vstinner
Copy link
Member

I don't think that it should be possible to serialize a Compressor or Decompressor object. There is no getstate/setstate or reduce methods which would serialize attributes only accessible in C. More generally, I don't think that it would be useful, nor needed.

See https://bugs.python.org/issue40077#msg371813

@corona10 corona10 marked this pull request as ready for review June 18, 2020 17:04
@corona10
Copy link
Member Author

@vstinner Thanks updated!

@corona10 corona10 requested a review from vstinner June 18, 2020 17:06
@corona10 corona10 requested a review from vstinner June 19, 2020 14:21
@corona10 corona10 requested a review from vstinner June 19, 2020 14:54
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants